On 17/01/2024 9:37 am, Jan Beulich wrote: > This way ioemul_handle_proliant_quirk() won't need ENDBR anymore. > > While touching this code, also > - arrange for it to not be built at all when !PV, > - add "const" to the last function parameter and bring the definition > in sync with the declaration (for Misra). > > Signed-off-by: Jan Beulich <[email protected]>
Reviewed-by: Andrew Cooper <[email protected]> > --- > Obviously the file may want moving to pv/ then. I wasn't sure whether > to also fold doing so right into here. I'm sure we discussed this before, but I don't think we had a firm conclusion. IIRC there was a concern that we might need it for PVH dom0 too, depending on the degree to which the CLI is actually necessary here. The CLI is definitely not NMI safe, and whatever SMM logic we're tickling here should be synchronous with the INB. At a guess the CLI is just to get the RPC all done without adverse delay, but there is a distinct lack of useful information here. ~Andrew
