On 15.01.2024 15:50, Elias El Yandouzi wrote: > On 12/01/2024 07:47, Jan Beulich wrote: >> On 11.01.2024 19:25, Elias El Yandouzi wrote: >>> How would you proceed? Calling vmap() seems to be a bit overkill for >>> just a temporary mapping and I don't really want to rework this function >>> to use map_domain_page(). >>> >>> In such case, how would you proceed? What do you suggest? >> >> fixmap may be an option to consider, but I also don't see why you >> apparently think using vmap() would be a possibility while at the >> same time making use of map_domain_page() is too much effort. > > I thought about using vmap() as it allows to map a contiguous region > easily. It is also used in the follow-up patch 17/22, so I thought it > could be viable. > > I was reluctant to use map_domain_page() for two reasons. 1) it only > allows to map one page at the time, so I'd need to rework more deeply > the function dmi_iterate() 2) because the mapcache wouldn't be ready to > use at that time, the mapping would end up in PMAP which is meant to map > the page tables, nothing else.
Oh, right, this makes sense of course. Jan
