On 11/01/2024 7:32 am, Jan Beulich wrote: > Move functions (and their data) to common code, and invoke the functions > on Arm as well. This is in preparation of dropping the register > parameters from handler functions. > > Signed-off-by: Jan Beulich <[email protected]>
Reviewed-by: Andrew Cooper <[email protected]> with one wording suggestion. > --- > To limit visibility of the per-CPU data item, we may want to consider > making the functions out-of-line ones (in common/irq.c). If we had working LTO, then maybe. But we don't, and I think we can reasonably cover (not using) this with normal code review. > --- a/xen/include/xen/irq.h > +++ b/xen/include/xen/irq.h > @@ -131,6 +131,26 @@ void cf_check irq_actor_none(struct irq_ > #define irq_disable_none irq_actor_none > #define irq_enable_none irq_actor_none > > +/* > + * Per-cpu interrupted context register state - the top-most interrupt frame > + * on the stack. The prior wording "last" wasn't great either. I'd suggest "inner-most". "top-most" comes with the usual confusions with stacks being upside down, and inner/outer is more common terminology with nesting. ~Andrew
