Subject s/logging/9pfs/ On 04/01/2024 9:00 am, Juergen Gross wrote: > diff --git a/tools/xen-9pfsd/xen-9pfsd.c b/tools/xen-9pfsd/xen-9pfsd.c > new file mode 100644 > index 0000000000..22cfff0c4e > --- /dev/null > +++ b/tools/xen-9pfsd/xen-9pfsd.c > @@ -0,0 +1,145 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > + > +/* > + * xen-9pfsd - Xen 9pfs daemon > + * > + * Copyright (C) 2023 Juergen Gross <[email protected]>
Presumably the year wants bumping now? Both can be fixed on commit. This is otherwise looking fine now. Acked-by: Andrew Cooper <[email protected]>, although one other suggestion > +static void do_err(const char *msg) > +{ > + syslog(LOG_ALERT, "%s, errno = %d", msg, errno); ... errno %d, %s" also passing in strerror() for the benefit of those who don't know the errno number off by heart? ~Andrew
