Hi Ayan, > On 18 Dec 2023, at 20:29, Ayan Kumar Halder <[email protected]> wrote: > > Hi, > > Refer > https://lore.kernel.org/all/alpine.DEB.2.22.394.2312071341540.1265976@ubuntu-linux-20-04-desktop/T/ > for the previous discussion on this issue. > > Also, the linux earlycon hvc driver has been fixed. > See > https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git/commit/?h=tty-next&id=0ec058ece2f933aed66b76bd5cb9b5e6764853c3 > > Changes from v1:- > 1. Split the change across 3 patches as per the design consensus. > > Ayan Kumar Halder (3): > xen/arm: Add emulation of Debug Data Transfer Registers > xen: arm: Introduce CONFIG_PARTIAL_EMULATION > xen/arm: Introduce "partial-emulation" xen command line option
I’m a bit puzzled about the order of these changes, wouldn’t be better to Introduce the partial emulation Kconfig and command line args in the same patch together with something that uses it? I think here you wanted to keep Michal patch untouched, but I feel that a correct split for this serie would be maybe introducing Kconfig, boot args and one of the arm64/arm32 emulation, and on a second patch the other one (Or vice-versa)? If there is something that I’m missing let me know. > > docs/misc/xen-command-line.pandoc | 7 +++++ > xen/arch/arm/Kconfig | 8 +++++ > xen/arch/arm/arm64/vsysreg.c | 32 ++++++++++++++++--- > xen/arch/arm/include/asm/arm64/hsr.h | 3 ++ > xen/arch/arm/include/asm/cpregs.h | 2 ++ > xen/arch/arm/include/asm/regs.h | 6 ++++ > xen/arch/arm/include/asm/traps.h | 4 +++ > xen/arch/arm/traps.c | 21 +++++++++++++ > xen/arch/arm/vcpreg.c | 47 +++++++++++++++++++++++----- > 9 files changed, 117 insertions(+), 13 deletions(-) > > -- > 2.25.1 > >
