On 19.12.2023 21:31, Andrew Cooper wrote: > On 15/12/2023 11:18 am, Roger Pau Monne wrote: >> + if ( system_state < SYS_STATE_active ) >> + printk(XENLOG_ERR "%s test failed\n", tests[i].name); > > This is a test hypercall, for the purpose of running testing, in > combination with test livepatches. Eliding the diagnostics isn't ok. > > Logspam concerns aren't an issue. If the user runs `while :; do > xen-test-smc; done` in dom0 then they get to have a full dmesg ring. > > Don't let that get in the way of having a sensible time figuring out > what went wrong.
Since it was me who asked to suppress this when invoked through sysctl: I can live with an unconditional printk() here, but I think this goes against the "what can be done in user space should be done there" principle: If enough information is propagated back, user space should be able to provide all necessary output without even a need for the observer to run "xl dmesg". Jan
