On Thu, 2023-12-14 at 16:05 +0100, Jan Beulich wrote:
> On 24.11.2023 11:30, Oleksii Kurochko wrote:
> > --- /dev/null
> > +++ b/xen/arch/riscv/include/asm/regs.h
> > @@ -0,0 +1,26 @@
> > +#ifndef __ARM_RISCV_REGS_H__
> > +#define __ARM_RISCV_REGS_H__
> > +
> > +#ifndef __ASSEMBLY__
> > +
> > +#include <xen/bug.h>
> > +#include <asm/current.h>
> 
> Does one of these bring in asm/processor.h, for ...
> 
> > +#define hyp_mode(r)     (0)
> > +
> > +static inline bool guest_mode(const struct cpu_user_regs *r)
> 
> ... struct cpu_user_regs to be available? Else a forward declaration
> would be needed here.
Agreed. It will be better to use a forward declaration. I'll change
that in next patch series.

> 
> Acked-by: Jan Beulich <[email protected]>
Thanks.

~ Oleksii

Reply via email to