On Thu, 2023-12-14 at 14:27 +0100, Jan Beulich wrote: > On 24.11.2023 11:30, Oleksii Kurochko wrote: > > Signed-off-by: Oleksii Kurochko <[email protected]> > > Did you write this code from scratch? If not, you need to at least > point > out the origin. But: None of this looks RISC-V specific, so shouldn't > it > instead be put under xen/lib/, as a fallback implementation for arch- > es > not having optimized implementations? Looks also at least very > similar > to Arm64's, so that one perhaps then will want dropping as well? We > surely don't want to carry two (almost) identical copies of the same > logic. No, I took the code from Arm because as you mentioned it doesn't have RISC-V specific things.
I think we can move it to xen/lib. Would it be better to as part of this patch series? > > > --- /dev/null > > +++ b/xen/arch/riscv/lib/Makefile > > @@ -0,0 +1 @@ > > +obj-y += find_next_bit.o > > Dashes instead of underscores please in new file's names, whenever > possible. Sure. I'll update that. Thanks. ~ Oleksii
