Hi Julien, Thank you for the feedback. Most of your points will be addressed by following your suggestion of moving ARM's bootfdt.c to common, but I wanted to respond with a few points of clarification.
On 12/1/23 5:23 PM, Julien Grall wrote: > * fdt_get_mem_rsv_paddr(), this is part of the DT is used to reserve > memory. This was superseed to /reserved-memory, but I wonder how > widespread this is on PPC? As far as I can tell, the DT reserve memory map is not used on PPC/PowerNV. This information is instead communicated through `reserved-memory` nodes in the DT itself, which the existing code handles. > * If am not mistaken you are adding the Xen module as BOOTMOD_KERNEL, > however this is meant to be used for the domain kernel. Xen should be > BOOTMOD_XEN. Thank you for pointing this out -- BOOTMOD_XEN is indeed the correct choice here. > I hope that helps. > > Cheers, > Thanks, Shawn
