On 12.12.2023 10:53, Nicola Vetrini wrote:
> On 2023-12-12 10:45, Jan Beulich wrote:
>> On 11.12.2023 11:30, Nicola Vetrini wrote:
>>> @@ -38,39 +38,32 @@ void hwdom_shutdown(u8 reason)
>>> printk("Hardware Dom%u halted: halting machine\n",
>>> hardware_domain->domain_id);
>>> machine_halt();
>>> - break; /* not reached */
>>>
>>> case SHUTDOWN_crash:
>>> debugger_trap_immediate();
>>> printk("Hardware Dom%u crashed: ",
>>> hardware_domain->domain_id);
>>> kexec_crash(CRASHREASON_HWDOM);
>>> maybe_reboot();
>>> - break; /* not reached */
>>
>> Given the function's name, I don't view this removal (and the similar
>> one
>> further down) as acceptable. The function first needs renaming so that
>> from its name one can no longer (wrongly) infer that it may reboot or
>> else
>> return.
>
> Something like "reboot_or_halt" would be okay?
I think so, yes.
Jan
