Re: [PATCH] OSStest: use CONFIG_X86_GENERIC for 32-bit x86 kernel

[Juergen Gross]

On 08.12.23 16:59, Anthony PERARD wrote:

On Thu, Dec 07, 2023 at 09:09:53AM +0100, Juergen Gross wrote:

Today the cpu type for a 32-bit x86 kernel is not specified in the
used kernel config, resulting in the M686 to be used.

Instead of using the M686 which isn't even a 64-bit cpu (thus not
capable to run a Xen guest), use the X86_GENERIC variant which is
more appropriate.

Signed-off-by: Juergen Gross <jgr...@suse.com>
---
  ts-kernel-build | 5 ++++-
  1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/ts-kernel-build b/ts-kernel-build
index 719b33aa..d9e033c4 100755
--- a/ts-kernel-build
+++ b/ts-kernel-build
@@ -608,7 +608,10 @@ setopt CONFIG_POWER_RESET_XGENE y
  setopt CONFIG_RTC_DRV_XGENE y

-    x86_32) setopt CONFIG_64BIT n ;;
+    x86_32)
+       setopt CONFIG_64BIT n
+       setopt CONFIG_X86_GENERIC y

case ${XEN_TARGET_ARCH} in

It would be nice if that was working, but XEN_TARGET_ARCH is never set,
so the change isn't going to work.

I'm preparing patches to set X86_GENERIC on i386 builds, and fixing some
issues.

Oh, BTW, I think it might be a good idea to add a MAINTAINERS entry in the
Xen git tree for OSStest. I was pretty sure you are the one to send patches
to, but maybe someone else should receive them?


Juergen

OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

OpenPGP_signature.asc
Description: OpenPGP digital signature