On 28.11.2023 22:28, Shawn Anastasio wrote: > On 11/27/23 8:13 AM, Oleksii Kurochko wrote: >> --- a/xen/arch/ppc/include/asm/irq.h >> +++ b/xen/arch/ppc/include/asm/irq.h >> @@ -3,7 +3,9 @@ >> #define __ASM_PPC_IRQ_H__ >> >> #include <xen/lib.h> >> +#ifdef CONFIG_HAS_DEVICE_TREE > > I realize that you were likely following PPC's device.h which also > checks CONFIG_HAS_DEVICE_TREE, but I'm not sure that it makes sense to > check this conditional in PPC code at all -- we will always have > HAS_DEVICE_TREE (selected by PPC) and I can't imagine a scenario where > this will ever not be the case. > > Unless Jan (or someone else) disagrees, I'd rather this conditional be > dropped inside of PPC code.
No, pointless #ifdef are indeed better avoided. Jan
