On 20.11.2023 20:45, Andrew Cooper wrote: > sysenter_eflags_saved() and int80_direct_trap() are now only used by a single > translation unit. Move the declarations into the respective traps.c, renaming > int80_direct_trap() to entry_int80() to match the style elsewhere. > > Annotate all 3 with nocall like all other entry paths. > > Signed-off-by: Andrew Cooper <[email protected]>
Reviewed-by: Jan Beulich <[email protected]> Nevertheless I wonder if this wouldn't better be deferred until asmlinkage has appeared in the code base, such that along with nocall that could be added at the same time. (Even then it's not entirely clear to me whether Misra is going to be happy with declarations not living in headers. But imo limiting exposure trumps Misra's possible pickiness.) Jan
