On 09.11.2023 19:27, Stewart Hildebrand wrote: > --- a/xen/include/xen/iommu.h > +++ b/xen/include/xen/iommu.h > @@ -245,6 +245,8 @@ int iommu_do_dt_domctl(struct xen_domctl *domctl, struct > domain *d, > */ > int iommu_remove_dt_device(struct dt_device_node *np); > > +#define NO_IOMMU 1 > + > #endif /* HAS_DEVICE_TREE */
When looking just here (i.e. once that was committed, when looking just at the header) it is entirely unclear what this #define's purpose is. My first guess was a bogus attempt to escape using some CONFIG_* setting. Looking at the use sites, this looks to be a kind-of-error-code. That wants saying here in a comment, alongside the scope of where this may be validly used. Jan
