On Tue, 2023-10-24 at 15:47 +0100, Paul Durrant wrote:
>
> >
> > - if (netdev->xendev.be_state != XenbusStateConnected) {
> > + if (netdev->rx_ring.sring == NULL) {
>
> Why not a straight swap for xen_device_backend_get_state()? Hard to see
> whether there any hidden side effects of this change otherwise.I suppose if I litter it with a few assertions that the iothread mutex is locked, I can live with that. As long as it's atomic w.r.t. disconnection, they *are* identical checks. (And if it could be running simultaneously with disconnection, we'd be hosed anyway).
smime.p7s
Description: S/MIME cryptographic signature
