Hi Julien,

(+Stefano and Bertrand)

> On Oct 24, 2023, at 01:52, Julien Grall <[email protected]> wrote:
> 
> From: Julien Grall <[email protected]>
> 
> The 'break' the XEN_DOMCTL_set_address_size is unreachable and tools
> like Eclair will report as a violation of Misra Rule 2.1.
> 
> Furthermore, the nested switch is not very easy to read. So move
> out the nested switch in a separate function to improve the
> readability and hopefully address the MISRA violation.
> 
> Reported-by: Nicola Vetrini <[email protected]>
> Signed-off-by: Julien Grall <[email protected]>

Reviewed-by: Henry Wang <[email protected]>

> ---
> Only compiled tested. Waiting for the CI to confirm there is no
> regression.

I also tested this patch on top of today’s staging in Arm’s internal CI, and 
this
patch looks good.

Tested-by: Henry Wang <[email protected]>

Kind regards,
Henry


Reply via email to