On 13.10.2023 17:38, Alejandro Vallejo wrote:
> Fix adapted off Linux's mailing list:
>
> https://lore.kernel.org/lkml/[email protected]/T/#u
Why reference the bug report when there's a proper commit (f454b18e07f5) now?
Plus in any event a short summary of the erratum would help if put right here
(without needing to look up any documents or follow any links).
> --- a/xen/arch/x86/cpu/amd.c
> +++ b/xen/arch/x86/cpu/amd.c
> @@ -1004,6 +1004,28 @@ static void cf_check zen2_disable_c6(void *arg)
> wrmsrl(MSR_AMD_CSTATE_CFG, val & mask);
> }
>
> +static void amd_check_erratum_1485(void)
> +{
> + uint64_t val, chickenbit = (1 << 5);
Linux gives the bit a name. Any reason you don't?
Everything else lgtm.
Jan
