On 12.10.2023 17:28, Nicola Vetrini wrote: > --- a/xen/include/xen/types.h > +++ b/xen/include/xen/types.h > @@ -22,6 +22,14 @@ typedef signed long ssize_t; > > typedef __PTRDIFF_TYPE__ ptrdiff_t; > > +/* > + * Users of this macro are expected to pass a positive value.
Is passing 0 going to cause any issues? > + * Eventually, this should become an unsigned quantity, but this > + * requires fixing various uses of this macro and BITS_PER_LONG in signed > + * contexts, such as type-safe 'min' macro uses, which give rise to build > errors > + * when the arguments have differing signedness, due to the build flags used. > + */ I'm not convinced of the usefulness of this part of the comment. Jan > #define BITS_TO_LONGS(bits) \ > (((bits)+BITS_PER_LONG-1)/BITS_PER_LONG) > #define DECLARE_BITMAP(name,bits) \
