Hi,

> On Oct 6, 2023, at 22:55, Andrew Cooper <[email protected]> wrote:
> 
> On 06/10/2023 3:50 pm, Roger Pau Monne wrote:
>> The script heavily relies on the urlgrabber python module, which doesn't seem
>> to be packaged by all distros, it's missing from newer Debian versions at
>> least.
>> 
>> Also the usage of the commands module has been deprecated since Python 2.6, 
>> and
>> removed in Python 3, so the code would need to be re-written to not rely on
>> urlgrabber and the commands modules.
>> 
>> Arguably the purpose of the xenpvnetboot bootloader can also be achieved with
>> an isolated script that fetches the kernel and ramdisk before attempting to
>> launch the domain, without having to run in libxl context.  There are no 
>> xl.cfg
>> options consumed by the bootloader apart from the base location and the
>> subpaths of the kernel and ramdisk to fetch.
>> 
>> Any interested parties in keeping such functionality are free to submit an
>> updated script that works with Python 3.
> 
> Resolves: xen-project/xen#172
> 
>> Signed-off-by: Roger Pau MonnĂ© <[email protected]>
> 
> Reviewed-by: Andrew Cooper <[email protected]>

Release-acked-by: Henry Wang <[email protected]>

> 
> Thanks for doing this.

+1

Kind regards,
Henry

> 
> ~Andrew

Reply via email to