Hi Leo,

Adding some comments on top of what already said.

On 26/09/2023 06:33, Leo Yan wrote:
+static bool __init memory_node_is_available(const void *fdt, unsigned long 
node)
+{
+    const char *status = fdt_getprop(fdt, node, "status", NULL);
+
+    if (!status)
+        return true;
+

We have a similar implement based on the unflatten DT (see dt_device_is_available()). While trying to consolidate them is probably not worth it, I think the behavior should match.

In this case, you want to check the len is greater than 0 before doing the comparison.

Cheers,

--
Julien Grall

Reply via email to