On 01.07.2023 09:18, Christopher Clark wrote: > To convert the x86 boot logic from multiboot to boot module structures, > change the bootstrap map function to accept a boot module parameter. > > To allow incremental change from multiboot to boot modules across all > x86 setup logic, provide a temporary inline wrapper that still accepts a > multiboot module parameter and use it where necessary.
And all uses of the original function are converted to the new wrapper, except when passing NULL - am I getting this right? Plus down the road you'll change all of them back? Too much code churn for my taste, to be honest, not the least because this undermines easy use of "git blame". If the above observation is right, and since passing NULL to the wrapper is fine too, why don't you deal with this by using a macro wrapper instead, without needing to touch all the call sites: #define bootstrap_map(m) bootstrap_map_multiboot(m) Misra won't like that, but as you say it's temporary. Jan
