On 04.09.2023 15:42, Bertrand Marquis wrote:
>> On 1 Sep 2023, at 09:26, Jan Beulich <[email protected]> wrote:
>>
>> This using a GNU extension, it may not be exposed in general, just like
>
> Nit: Missing "is"
I would guess you would want it added as the 2nd word of the sentence. If
not, please clarify where you think it is missing. If so, then I'm afraid
I can't parse the sentence anymore with it added (i.e. there would need
to be further modifications, e.g. at the very least "so" after the first
comma).
>> is done on x86. External consumers need to make this type available up
>> front (just like we expect {,u}int<N>_t to be supplied) - unlike on x86
>> the type is actually needed outside of tools-only interfaces, because
>> guest handle definitions use it.
>>
>> While there also add underscores around "aligned".
>>
>> Signed-off-by: Jan Beulich <[email protected]>
>
> With the Nit fixed (can be done on commit):
>
> Reviewed-by: Bertrand Marquis <[email protected]>
Thanks, but I'm afraid I can't take it before the above is clarified.
Jan
