Hi Henry, On 14/08/2023 05:25, Henry Wang wrote:
The original assembly setup_fixmap() is actually doing two seperate tasks, one is enabling the early UART when earlyprintk on, and the other is to set up the fixmap (even when earlyprintk is off).Per discussion in [1], since commit 9d267c049d92 ("xen/arm64: Rework the memory layout"), there is no chance that the fixmap and the mapping of early UART will clash with the 1:1 mapping. Therefore the mapping of both the fixmap and the early UART can be moved to the end of create_pagetables(). No functional change intended.
I would drop this sentence because the fixmap is now prepared much earlier in the code. So there is technically some functional change.
[1] https://lore.kernel.org/xen-devel/[email protected]/ Signed-off-by: Henry Wang <[email protected]>
Reviewed-by: Julien Grall <[email protected]> Cheers, -- Julien Grall
