On Mon, 31 Jul 2023, Nicola Vetrini wrote: > On 31/07/2023 16:16, Jan Beulich wrote: > > On 31.07.2023 15:34, Nicola Vetrini wrote: > > > --- a/xen/drivers/passthrough/pci.c > > > +++ b/xen/drivers/passthrough/pci.c > > > @@ -650,12 +650,12 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn, > > > struct pci_seg *pseg; > > > struct pci_dev *pdev; > > > unsigned int slot = PCI_SLOT(devfn), func = PCI_FUNC(devfn); > > > - const char *pdev_type; > > > + const char *pci_dev_type; > > > > I've always been wondering what purpose the pdev_ prefix served here. > > There's no other "type" variable in the function, so why make the name > > longer? (I'm okay to adjust on commit, provided you agree.) > > > > Jan > > No objections.
I reviewed the patch and it is correct: Reviewed-by: Stefano Stabellini <[email protected]> Jan, feel free to pick any name you prefer on commit, e.g. "type".
