Hi Jan,

> On 21 Jul 2023, at 10:52, Jan Beulich <[email protected]> wrote:
> 
> On 21.07.2023 10:02, Bertrand Marquis wrote:
>> --- a/xen/arch/arm/tee/Kconfig
>> +++ b/xen/arch/arm/tee/Kconfig
>> @@ -1,7 +1,17 @@
>> +menu "TEE mediators"
>> + visible if UNSUPPORTED
> 
> With this ...
> 
>> +config TEE
>> + bool
>> + default n
>> + help
>> +  This option enables generic TEE mediators support. It allows guests
>> +  to access real TEE via one of TEE mediators implemented in XEN.
>> +
>> config OPTEE
>> - bool "Enable OP-TEE mediator"
>> + bool "Enable OP-TEE mediator (UNSUPPORTED)" if UNSUPPORTED
> 
> ... you shouldn't need the "if" here, and ...
> 
>> default n
>> - depends on TEE
>> + select TEE
>> help
>>  Enable the OP-TEE mediator. It allows guests to access
>>  OP-TEE running on your platform. This requires
>> @@ -13,9 +23,13 @@ config FFA
>> bool "Enable FF-A mediator support (UNSUPPORTED)" if UNSUPPORTED
> 
> ... you could drop the one here. I think.

visible if is only for the GUI/ncurse display but the if is required
to make sure that a .config file cannot set CONFIG_TEE or
CONFIG_FFA if. UNSUPPORTED is not selected.

Bertrand


Reply via email to