On 17.07.2023 12:33, Andrew Cooper wrote: > On 17/07/2023 10:17 am, Jan Beulich wrote: >> /* Intel defined MSRs. */ >> -#define MSR_IA32_P5_MC_ADDR 0x00000000 >> -#define MSR_IA32_P5_MC_TYPE 0x00000001 > > These are architectural. They still exist in all Intel and AMD CPUs. > > I'd suggest keeping them, because I think we're required to expose them > when advertising MCA.
We have them twice, and I've kept the instances without IA32 in their names (at the very top of the file, i.e. already in the "new style" section). Jan
