On Tue, Jul 11, 2023 at 03:28:28PM -0400, Stewart Hildebrand wrote:
> When mapping BARs for vPCI, it's valid for a BAR start address to equal the
> BAR
> end address (i.e. s == e) since e is inclusive. However, pci_check_bar()
> currently returns false in this case, which results in Xen not mapping the
> BAR.
> In this example boot log, Linux has mapped the BARs, but since Xen did not map
> them, Linux encounters a data abort and panics:
I would maybe reword this a bit to clarify that Xen has not mapped the
BARs in the guest second stage page tables, 'Xen is not mapping the
BAR' is IMO too vague.
>
> [ 2.593300] pci 0000:00:00.0: BAR 0: assigned [mem 0x50008000-0x50008fff]
> [ 2.593682] pci 0000:00:00.0: BAR 2: assigned [mem 0x50009000-0x50009fff]
> [ 2.594066] pci 0000:00:00.0: BAR 4: assigned [mem 0x5000a000-0x5000afff]
> ...
> [ 2.810502] virtio-pci 0000:00:00.0: enabling device (0000 -> 0002)
> (XEN) 0000:00:00.0: not mapping BAR [50008, 50008] invalid position
> (XEN) 0000:00:00.0: not mapping BAR [50009, 50009] invalid position
> (XEN) 0000:00:00.0: not mapping BAR [5000a, 5000a] invalid position
> [ 2.817502] virtio-pci 0000:00:00.0: virtio_pci: leaving for legacy driver
> [ 2.817853] virtio-pci 0000:00:00.0: enabling bus mastering
> (XEN) arch/arm/traps.c:1992:d0v0 HSR=0x00000093010045 pc=0xffff8000089507d4
> gva=0xffff80000c46d012 gpa=0x00000050008012
> [ 2.818397] Unable to handle kernel ttbr address size fault at virtual
> address ffff80000c46d012
> ...
>
> Since e is inclusive, drop the equality check.
>
> Also, adjust e to include the whole page. This increases the accuracy of the
> subsequent is_bar_valid check.
I think you want to reorder those sentences, when e is adjusted to
account for the full page s == e is actually impossible, hence the =
part of the check can be dropped:
"Adjust the end physical address to account for the full page when
converting from mfn, at which point start and end cannot be equal, so
drop the equal check in the condition."
Or something similar.
The rest LGTM.
>
> Fixes: cc80e2bab0d0 ("xen/pci: replace call to is_memory_hole to
> pci_check_bar")
> Signed-off-by: Stewart Hildebrand <[email protected]>
With the above adjusted:
Reviewed-by: Roger Pau Monné <[email protected]>
Thanks, Roger.
