On Mon, Jul 10, 2023 at 06:27:06PM +0200, Jan Beulich wrote:
> On 10.07.2023 16:12, Roger Pau Monne wrote:
> > Commit 9473d9a24182 set the ASK mode without checking if there was a
> > `vga` option provided in the command line. This breaks existing
> > behavior, so exit early without changes if `vga` is not present in the
> > command line.
> >
> > Fixes: 9473d9a24182 ('cmdline: parse multiple instances of the vga option')
> > Signed-off-by: Roger Pau Monné <[email protected]>
>
> Reviewed-by: Jan Beulich <[email protected]>
>
> Should have spotted this during review; effectively you're (almost) undoing
> part of the earlier change, just that ...
>
> > --- a/xen/arch/x86/boot/cmdline.c
> > +++ b/xen/arch/x86/boot/cmdline.c
> > @@ -279,9 +279,13 @@ static void vga_parse(const char *cmdline,
> > early_boot_opts_t *ebo)
> > {
> > const char *c = cmdline;
> >
> > + c = find_opt(c, "vga=", true);
>
> ... you use c instead of cmdline here (and I'm heavily tempted to actually
> make this the initializer of c).
I see, yes, please do.
Thanks, Roger.
