On 14.06.2023 11:41, Michal Orzel wrote: > This is inconsistent with the rest of the code where macros are used > to define functions, as it results in an empty declaration (i.e. > semicolon with nothing before it) after function definition. This is also > not allowed by C99. > > Take the opportunity to undefine TLB_HELPER* macros after last use. > > Signed-off-by: Michal Orzel <[email protected]> > --- > Discussion: > https://lore.kernel.org/xen-devel/[email protected]/ > > Other empty declarations appear at callers of TYPE_SAFE and Linux module > macros like EXPORT_SYMBOL for which we need some sort of agreement.
As said elsewhere, I think we should finally get rid of EXPORT_SYMBOL(). For TYPE_SAFE() I think some re-arrangement of the macros can address the Misra concern. Jan
