> On 19 May 2023, at 08:08, Michal Orzel <[email protected]> wrote: > > Hi Luca, > > On 17/05/2023 02:44, Stefano Stabellini wrote: >> >> >> On Thu, 4 May 2023, Luca Fancellu wrote: >>> repository in the reports >>> >>> Currently the cppcheck report entries shows the relative file path >>> from the /xen folder of the repository instead of the base folder. >>> In order to ease the checks, for example, when looking a git diff >>> output and the report, use the repository folder as base. >>> >>> Signed-off-by: Luca Fancellu <[email protected]> >> >> Acked-by: Stefano Stabellini <[email protected]> >> Tested-by: Stefano Stabellini <[email protected]> > > I know this patch is now committed but there is something confusing here. > At the moment, in the cppcheck report we have paths relative to xen/ e.g.: > arch/arm/arm64/lib/bitops.c(117,1):... > > So after this patch, I would expect to see the path relative to root of > repository e.g.: > *xen/*arch/arm/arm64/lib/bitops.c(117,1):... > > However, with or without this patch the behavior is the same. > Did I misunderstand your patch?
Hi Michal, Thank you for having spotted this, during my tests I was using Xen-analysis.py so that it calls the makefile with out-of-tree build, I’ve found after your mail that when it calls the makefile with in-tree-build, cppcheck is run from /xen/xen and it causes it to produce relative path from there in the TXT fragments, showing the issue you observed. I have ready a fix for that and I’ll push that soon. > > ~Michal
