On 04.05.2023 19:24, Andrew Cooper wrote: > On 04/05/2023 5:16 pm, Jan Beulich wrote: >> Presumably by copy-and-paste we've accumulated a number of instances of >> $(@D)/$(@F), which really is nothing else than $@. The split form only >> needs using when we want to e.g. insert a leading . at the beginning of >> the file name portion of the full name. > > From the Kbuild work, we have $(dot-target) now which is marginally more > legible than $(@D)/.$(@F), and we ought to use it consistently.
Oh, right - let me make yet another patch on top. >> Signed-off-by: Jan Beulich <[email protected]> > > Acked-by: Andrew Cooper <[email protected]>, although ... Thanks. >> --- a/xen/arch/arm/Makefile >> +++ b/xen/arch/arm/Makefile >> @@ -104,9 +104,9 @@ $(TARGET)-syms: $(objtree)/prelink.o $(o >> $(MAKE) $(build)=$(@D) $(@D)/.$(@F).1.o >> $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds -N $< $(build_id_linker) \ >> $(@D)/.$(@F).1.o -o $@ >> - $(NM) -pa --format=sysv $(@D)/$(@F) \ >> + $(NM) -pa --format=sysv $@ \ >> | $(objtree)/tools/symbols --all-symbols --xensyms --sysv >> --sort \ >> - >$(@D)/$(@F).map >> + >[email protected] > > ... any chance we can get a space between > and $ like we do almost > everywhere else? Since "almost everywhere else" wasn't quite right for xen/arch/*/Makefile I was first inclined to say no, but I can easily insert blanks when doing the $(dot-target) conversion as well, and then it looks like it'll end up fully consistent (in this one regard). Jan
