On Tue, May 02, 2023 at 12:13:37PM +0100, Alejandro Vallejo wrote:
> diff --git a/tools/libs/light/libxl_x86_acpi.c
> b/tools/libs/light/libxl_x86_acpi.c
> index 22eb160659..796b009d0c 100644
> --- a/tools/libs/light/libxl_x86_acpi.c
> +++ b/tools/libs/light/libxl_x86_acpi.c
> @@ -87,14 +87,14 @@ static int init_acpi_config(libxl__gc *gc,
> {
> xc_interface *xch = dom->xch;
> uint32_t domid = dom->guest_domid;
> - xc_dominfo_t info;
> + xc_domaininfo_t info;
> struct hvm_info_table *hvminfo;
> int i, r, rc;
>
> config->dsdt_anycpu = config->dsdt_15cpu = dsdt_pvh;
> config->dsdt_anycpu_len = config->dsdt_15cpu_len = dsdt_pvh_len;
>
> - r = xc_domain_getinfo(xch, domid, 1, &info);
> + r = xc_domain_getinfo_single(xch, domid, &info);
> if (r < 0) {
> LOG(ERROR, "getdomaininfo failed (rc=%d)", r);
You could change this error message. The value of 'r' isn't interesting
anymore. Instead, you could replace that by LOGE or LOGED (both will
print errno).
Otherwise, patch looks good:
Acked-by: Anthony PERARD <[email protected]>
Thanks,
--
Anthony PERARD
