On 28/04/2023 1:33 pm, Andrew Cooper wrote: > On 28/04/2023 11:41 am, Alejandro Vallejo wrote: >> It has 2 avoidable occurences >> >> * Check whether a domain is valid, which can be done faster with >> xc_domain_getinfo_single() >> * Domain discovery, which can be done much faster with the sysctl >> interface through xc_domain_getinfolist(). > It occurs to me that this isn't really right here. > > It's true in principle, but switching to requesting all domains at once > is a fix for a race condition. > > I'd suggest "which can be done in a race free way through ..." and avoid > saying faster. It's likely not faster now with the 4M bounce, but we > can fix that in due course.
Oh, there's also one tabs/spaces indentation hiccup. That can be fixed on commit too. ~Andrew
