On 19/04/2023 14:19, Michal Orzel wrote:
Hi Ayan,
Hi Michal, ...
--- /dev/null +++ b/xen/include/xen/libfdt/libfdt-xen.h @@ -0,0 +1,55 @@ +/* + * SPDX-License-Identifier: GPL-2.0-only Our CODING_STYLE says: New files should start with a single-line SPDX comment, ..., e.g. /* SPDX-License-Identifier: GPL-2.0 */ For me it would be perfectly fine to do as you did but it is not what our docs state (i.e. single-line comment). It might be that we need to modify CODING_STYLE instead.
Just to be clear, this is what we should have (as Julien had earlier suggested to use **GPL-2.0-only** )
diff --git a/xen/include/xen/libfdt/libfdt-xen.h b/xen/include/xen/libfdt/libfdt-xen.h
index 3296a368a6..cad7ad3bfb 100644 --- a/xen/include/xen/libfdt/libfdt-xen.h +++ b/xen/include/xen/libfdt/libfdt-xen.h @@ -1,6 +1,5 @@ +// SPDX-License-Identifier: GPL-2.0-only /* - * SPDX-License-Identifier: GPL-2.0-only - * * xen/include/xen/libfdt/libfdt-xen.h * * Wrapper functions for device tree. This helps to convert dt values - Ayan
