Hi Stewart, > -----Original Message----- > Subject: [PATCH 1/3] xen/arm: mark __guest_cmpxchg always_inline > > When building the hypervisor with -Og, we run into a __bad_cmpxchg link > error: > > aarch64-none-linux-gnu-ld: prelink.o: in function `__int_cmpxchg': > .../xen/./arch/arm/include/asm/arm64/cmpxchg.h:117: undefined reference > to `__bad_cmpxchg' > aarch64-none-linux-gnu- > ld: .../xen/./arch/arm/include/asm/arm64/cmpxchg.h:117: undefined > reference to `__bad_cmpxchg' > aarch64-none-linux-gnu-ld: ./.xen-syms.0: hidden symbol `__bad_cmpxchg' > isn't defined > aarch64-none-linux-gnu-ld: final link failed: bad value > > This is due to the function __guest_cmpxchg not being inlined in the -Og build > with gcc 12. Fix this by marking __guest_cmpxchg always_inline. > > Signed-off-by: Stewart Hildebrand <[email protected]
Hmmm I think you missed the ">" in the end of your signoff...But anyway the patch looks good to me so: Reviewed-by: Henry Wang <[email protected]> Kind regards, Henry
