On Wed, Feb 22, 2023 at 04:33:00PM +0100, Jens Wiklander wrote:
> diff --git a/tools/libs/light/libxl_types.idl
> b/tools/libs/light/libxl_types.idl
> index 0cfad8508dbd..64fb570bc19a 100644
> --- a/tools/libs/light/libxl_types.idl
> +++ b/tools/libs/light/libxl_types.idl
> @@ -494,7 +494,8 @@ libxl_gic_version = Enumeration("gic_version", [
>
> libxl_tee_type = Enumeration("tee_type", [
> (0, "none"),
> - (1, "optee")
> + (1, "optee"),
> + (2, "ffa")
Could you add a comma at the end of this line? This will avoid the need
to change two lines the next time we are adding a tee_type (like you
have to do now).
Also, as you are changing libxl's API, could you add a LIBXL_HAVE_*
macro in libxl.h? Something like:
/*
* arch_arm.tee field in libxl_domain_build_info has ffa value.
*/
#define LIBXL_HAVE_BUILDINFO_ARCH_ARM_TEE_FFA 1
Thanks,
--
Anthony PERARD
