> From: Jan Beulich <[email protected]> > Sent: Wednesday, February 15, 2023 9:55 AM > To: Ross Lagerwall <[email protected]> > Cc: Andrew Cooper <[email protected]>; George Dunlap > <[email protected]>; Julien Grall <[email protected]>; Stefano Stabellini > <[email protected]>; Wei Liu <[email protected]>; Anthony Perard > <[email protected]>; [email protected] > <[email protected]> > Subject: Re: [PATCH v2] build: Make FILE symbol paths consistent > > On 13.02.2023 17:55, Ross Lagerwall wrote: > > The FILE symbols in out-of-tree builds may be either a relative path to > > the object dir or an absolute path depending on how the build is > > invoked. Fix the paths for C files so that they are consistent with > > in-tree builds - the path is relative to the "xen" directory (e.g. > > common/irq.c). > > > > This fixes livepatch builds when the original Xen build was out-of-tree > > since livepatch-build always does in-tree builds. Note that this doesn't > > fix the behaviour for Clang < 6 which always embeds full paths. > > Is "fix" here actually correct? I.e. is there anything to fix in that > case? It looks to me as if "always absolute paths" is as good as > "always relative paths". In which case s/fix/alter/? >
If embedding absolute paths, the livepatch-build process will fail to match symbols between the base xen-syms and the newly built, patched objects unless they are built with the source directory at the exact same path. So yes, I would consider this as not "fixed" for Clang < 6. Thanks, Ross
