On 09.02.2023 12:40, Ross Lagerwall wrote: >> From: Jan Beulich <[email protected]> >> Sent: Thursday, February 9, 2023 8:44 AM >> >> On 08.02.2023 18:24, Ross Lagerwall wrote: >>> + rel_path = $(patsubst $(abs_srctree)/%,%,$(call realpath,$(1))) >> >> Personally I'm against use of underscores when dashes would do, and using >> a dash here would also be consistent with e.g. ... >> >>> cmd_objcopy_fix_sym = \ >>> - $(OBJCOPY) --redefine-sym $(<F)=$< $(dot-target).tmp $@ && rm -f >>> $(dot-target).tmp >>> + $(OBJCOPY) --redefine-sym $(<F)=$(call rel_path,$<) >>> $(dot-target).tmp $@ && rm -f $(dot-target).tmp >>> else >>> cmd_objcopy_fix_sym = mv -f $(dot-target).tmp $@ >>> endif >> >> ... the several visible uses of $(dot-target) here. > > I'm not sure if there is much consistency since other variables like > abs_srctree and abs_objtree also use underscores but I can change it > if you prefer.
These two variables had their names kept from their Linux origin, iirc, so they aren't an overly good target for comparison. Nor are, for the same reason, the various cmd_*. Linux, sadly, isn't consistent in that regard ... Jan
