> From: Xen-devel <[email protected]> on behalf of Mihails > Strasuns <[email protected]> > Sent: Thursday, January 19, 2023 10:13 AM > To: [email protected] <[email protected]> > Cc: [email protected] <[email protected]>; Michael Kurth <[email protected]> > Subject: [PATCH v1 1/4] common.h: Flush stdout before writing to stderr > > Flush existing debug messages before writing an error to stderr. stderr > is usually unbuffered and stdout is usually buffered. This results in > odd looking output when an error occurs and both stderr/stdout are > printed on the same console/file. More precisely, the error message is > printed in the middle of previously emitted debug messages. > > Signed-off-by: Michael Kurth <[email protected]> > --- > common.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/common.h b/common.h > index 02c9b7b..9a9da79 100644 > --- a/common.h > +++ b/common.h > @@ -10,6 +10,7 @@ extern char *childobj; > > #define DIFF_FATAL(format, ...) \ > ({ \ > + fflush(stdout); \ > fprintf(stderr, "ERROR: %s: " format "\n", childobj, ##__VA_ARGS__); > \ > error(2, 0, "unreconcilable difference"); \ > }) > -- > 2.38.1
Reviewed-by: Ross Lagerwall <[email protected]>
