On 31/01/2023 09:30, Henry Wang wrote:
Hi Julien,
-----Original Message-----
From: Julien Grall <[email protected]>
Subject: Re: [PATCH v3 1/3] xen/arm: Add memory overlap check for
bootinfo.reserved_mem
I will fix this patch and #2 in v4.
I am happy to deal with it on commit if you want.
Including adding the comment for both patches? This would be wonderful
and very nice of you to do that. But if your time is limited I am also more
than happy to respin the patch (probably even with Stefano's Reviewed-by
tag if he is ok with it) to reduce your burden. That said, if I need to respin
the
patch, it would be good to get some hints about the wording of the comments
to avoid another v+1 just because of my inaccurate wording :)
Good idea. My suggestion would be:
TODO: '*_end' could be 0 if the bank/region is at the end of the
physical address space. This is for now not handled as it requires more
rework.
Cheers,
--
Julien Grall
