Hi Henry, On 27/01/2023 12:15, Henry Wang wrote: > > > Hi Michal, > >> -----Original Message----- >>>> >>>> - BUG_ON(p2m_teardown(d, false)); >>> Because you remove this, >>>> ASSERT(page_list_empty(&p2m->pages)); >>> you no longer need this assert, right? >> I think the ASSERT() is still useful as it at least show that the pages >> should have been freed before the call to p2m_final_teardown(). > > I think I also prefer to have this ASSERT(), because of the exactly same > reason as Julien's answer. I think having this ASSERT() will help us to > avoid potential mistakes in the future. > > May I please ask if you are happy with keeping this ASSERT() and I can > carry your reviewed-by tag? Thanks! Yes, you can :)
~Michal
