On 18/01/2023 12:22 pm, David Woodhouse wrote: > Signed-off-by: David Woodhouse <[email protected]> > --- > What does xen_evtchn_do_upcall() exist for? Can we delete it? I don't > see it being called anywhere.
Seems the caller was dropped by cb09ea2924cbf1a42da59bd30a59cc1836240bcb, but the CONFIG_PVHVM looks bogus because the precondition to setting it up was being in a Xen HVM guest, and the guest is taking evtchns by vector either way. PV guests use the entrypoint called exc_xen_hypervisor_callback which really ought to gain a PV in its name somewhere. Also the comments look distinctly suspect. Some tidying in this area would be valuable. ~Andrew
