On 18/01/2023 07:15, Jan Beulich wrote: > On 17.01.2023 20:28, Per Bilse wrote: >> On 17/01/2023 15:55, Jan Beulich wrote: >>> On 16.01.2023 18:21, Per Bilse wrote: >>>> + config REBOOT_METHOD_XEN >>>> + bool "xen" >>>> + help >>>> + Use Xen SCHEDOP hypercall (if running under Xen as a >>>> guest). >>> >>> This wants to depend on XEN_GUEST, doesn't it? >> >> Yes, depending on context. In providing a compiled-in equivalent >> of the command-line parameter, it should arguably provide and accept >> the same set of options, but I'll change it. > > If consistency between the two cases is the goal, then why not adjust > command line handling (in a separate patch) to "not know" about "x" > when !XEN_GUEST?
Because that would be a different ticket, and we have enough tickets. :-) But no worries, your suggestions make perfect sense in a widened context, I just went with a minimalist interpretation in order to keep changes minimal. Best, -- Per
