On 11/01/2023 1:57 pm, Jan Beulich wrote:
> --- a/xen/arch/x86/mm/shadow/common.c
> +++ b/xen/arch/x86/mm/shadow/common.c
> @@ -2264,6 +2264,29 @@ void shadow_prepare_page_type_change(str
> shadow_remove_all_shadows(d, page_to_mfn(page));
> }
>
> +/*
> + * Removes v->arch.paging.shadow.shadow_table[].
> + * Does all appropriate management/bookkeeping/refcounting/etc...
> + */
> +static void sh_detach_old_tables(struct vcpu *v)
> +{
> + struct domain *d = v->domain;
> + unsigned int i;
> +
> + ////
> + //// vcpu->arch.paging.shadow.shadow_table[]
> + ////
Honestly, I don't see what the point of this comment is at all. I'd
suggest just dropping it as you move the function, which avoids the need
to debate over C++ comments.
Preferably with this done, Acked-by: Andrew Cooper
<[email protected]>
