(Cc to xen-devel@ re-added; I don't see why it was dropped)
On 07.12.2022 11:25, Per Bilse (3P) wrote:
> On 07/12/2022 09:05, Jan Beulich wrote:
>> On 06.12.2022 18:52, Per Bilse wrote:
>>> + if ( !s->enabled || (buffered &&
>>> + s->bufioreq_handling == HVM_IOREQSRV_BUFIOREQ_OFF) )
>>
>> Nit: Bad indentation. Since inserting the missing blanks would make
>> the line too long, the expression wants re-wrapping. Can certainly
>> be done while committing.
>
> Thanks for the feedback, but what should the indentation be (and where
> would I find the information)? I checked the coding style and it simply
> says "Long line should be split at sensible places and the trailing
> portions indented."
You'll find ample examples throughout the tree. Indentation of pieces
of expressions should be such that related pieces align. Hence in the
case here it could be
if ( !s->enabled || (buffered &&
s->bufioreq_handling == HVM_IOREQSRV_BUFIOREQ_OFF)
)
but since that's too long a line it'll want to be e.g.
if ( !s->enabled ||
(buffered && s->bufioreq_handling == HVM_IOREQSRV_BUFIOREQ_OFF) )
or
if ( !s->enabled ||
(buffered &&
s->bufioreq_handling == HVM_IOREQSRV_BUFIOREQ_OFF) )
(of which I prefer the former, and that's what I'll convert to if I
end up committing this change).
Jan
