On 06.12.2022 11:42, Andrew Cooper wrote:
>> --- a/xen/arch/x86/mm.c
>> +++ b/xen/arch/x86/mm.c
>> @@ -961,13 +961,10 @@ get_page_from_l1e(
>>
>
> As you noted that this desperately needs a comment, how about
>
> /* Force cacheable memtypes to UC, */
>
> here?
The comment you appear to be missing is actually there, just perhaps a
bit too far ahead:
/* MMIO pages must not be mapped cachable unless requested so. */
In any event the comment you suggest to add merely re-states in different
words what this earlier one already says.
Jan
