On Tue, Apr 24, 2018 at 10:58 AM, Ian Jackson <[email protected]> wrote: > perror() is defined to fprintf(stderr,...). HACKING says > fprintf(stderr,...) is wrong. So perror() is too. > > Signed-off-by: Ian Jackson <[email protected]> > CC: Paolo Bonzini <[email protected]> > CC: Markus Armbruster <[email protected]> > CC: Daniel P. Berrange <[email protected]> > CC: Michael Tokarev <[email protected]> > CC: Alistair Francis <[email protected]> > Reviewed-by: Philippe Mathieu-Daudé <[email protected]>
Reviewed-by: Alistair Francis <[email protected]> Alistair > --- > v7: New patch > --- > os-posix.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/os-posix.c b/os-posix.c > index a2ba50d..24eb700 100644 > --- a/os-posix.c > +++ b/os-posix.c > @@ -125,7 +125,7 @@ void os_set_proc_name(const char *s) > /* Could rewrite argv[0] too, but that's a bit more complicated. > This simple way is enough for `top'. */ > if (prctl(PR_SET_NAME, name)) { > - perror("unable to change process name"); > + error_report("unable to change process name: %s", strerror(errno)); > exit(1); > } > #else > @@ -247,7 +247,7 @@ static void change_root(void) > exit(1); > } > if (chdir("/")) { > - perror("not able to chdir to /"); > + error_report("not able to chdir to /: %s", strerror(errno)); > exit(1); > } > } > @@ -309,7 +309,7 @@ void os_setup_post(void) > > if (daemonize) { > if (chdir("/")) { > - perror("not able to chdir to /"); > + error_report("not able to chdir to /: %s", strerror(errno)); > exit(1); > } > TFR(fd = qemu_open("/dev/null", O_RDWR)); > @@ -383,7 +383,7 @@ int os_mlock(void) > > ret = mlockall(MCL_CURRENT | MCL_FUTURE); > if (ret < 0) { > - perror("mlockall"); > + error_report("mlockall: %s", strerror(errno)); > } > > return ret; > -- > 2.1.4 > > > _______________________________________________ > Xen-devel mailing list > [email protected] > https://lists.xenproject.org/mailman/listinfo/xen-devel _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
