Hi Vikram,
On 15/10/2022 06:07, Vikram Garhwal wrote:
+void xen_register_ioreq(XenIOState *state, unsigned int max_cpus,
+ MemoryListener xen_memory_listener)
+{
[...]
+
+ xen_bus_init();
+
+ /* Initialize backend core & drivers */
+ if (xen_be_init() != 0) {
+ error_report("xen backend core setup failed");
+ goto err;
+ }
+ xen_be_register_common();
Calling xen_be_init() and xen_be_register_common() from
xen_register_ioreq() sounds wrong to me. There are no dependency between
the two. I think it would be better to create a new function to register
backends.
Cheers,
--
Julien Grall
