Hi Jan, > -----Original Message----- > From: Jan Beulich <[email protected]> > Subject: [4.17?] Re: [PATCH] x86emul: respect NSCB > > On 10.10.2022 18:44, Andrew Cooper wrote: > > On 15/09/2022 08:22, Jan Beulich wrote: > >> protmode_load_seg() would better adhere to that "feature" of clearing > >> base (and limit) during NULL selector loads. > >> > >> Signed-off-by: Jan Beulich <[email protected]> > > > > Reviewed-by: Andrew Cooper <[email protected]> > > Thanks. > > Henry - this was submitted before the code freeze, so you weren't Cc-ed. > May I ask to consider giving this a release ack?
Since this patch is simple and to my best knowledge this patch is trying to improve the code so: Release-acked-by: Henry Wang <[email protected]> (If it will not cause too much time of digging, would you mind adding a "Fixes:" tag pointing to the original commit that missing this ` vcpu_has_nscb()` check when you do the committing? I think this would help to identify this patch as a bugfix so it is more reasonable to commit this patch in current phase. But if too much trouble or you think this is not really a fix then just ignore my comment...) Kind regards, Henry > > Thanks, Jan
