Roger Pau Monné writes ("Re: [PATCH] libvirt: disable Werror for non-libvirt
flights"):
> I don't mind using -Dwerror=false if that's considered better. Ian, do
> you have an opinion?
No, I don't think I do. I think it depends on what kinds of things
are likely to change, or go wrong, in libvirt.
- *) libvirt_build_runvars+=" make_njobs=1";;
+ *) libvirt_build_runvars+=" make_njobs=1
meson_options=-Dwerror=false autogen_options=--disable-werror";;
I wonder if it would be better to abstract this away and instead have
a runvar like "libvrit_build_werror=false". But maybe that is
gold-plating it.
If you choose to keep that the way it is, then for either version of
this patch:
Acked-by: Ian Jackson <[email protected]>
--
Ian Jackson <[email protected]> These opinions are my own.
Pronouns: they/he. If I emailed you from @fyvzl.net or @evade.org.uk,
that is a private address which bypasses my fierce spamfilter.
